Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update included Node to latest LTS version #831

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Update included Node to latest LTS version #831

merged 2 commits into from
Dec 10, 2018

Conversation

jmorrell
Copy link

@jmorrell jmorrell commented Dec 3, 2018

No description provided.

@jmorrell jmorrell requested a review from schneems December 3, 2018 18:12
@schneems schneems merged commit c422e34 into master Dec 10, 2018
@schneems
Copy link
Contributor

Thanks!

@luccasmaso
Copy link

luccasmaso commented Feb 6, 2019

@schneems Is there any reason from node version not be infered from node engine version inside package.json? Adding both ruby and node buildpacks to my app in Heroku causes yarn being called twice using a rails app with Webpacker (where the second time is called by rails assets:precompile).

I actually found out that rails/webpacker@386fd85
resolves the problem of yarn install invocation when assets precompile run. The problem is that only this last yarn install generates a manifest file for Webpacker. So, the yarn install from nodejs Buildpack is not enough relevant.

Webpacker can't find application in /app/public/packs/manifest.json. Possible causes:

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants